kvsari
Doomer
I like mapping.
Posts: 266
|
Post by kvsari on Jul 12, 2022 2:35:32 GMT -5
@gibbon As promised here's my question, posted in public so others can participate; Why does the PrBoom family of source ports ignore invalid command line parameters? Is it inertia (I think I remember original DOOM.EXE ignored bad command line params) and it never got fixed? To answer this question myself; it seems to be inertia and increasing complexity of code entering the command line params (storage?) in different ways making this fix difficult. Then you have a multitude of users with "incorrect" scripts which'll break if this is fixed. So it's a double no. If it does get fixed it'll happen on dsda-doom. Lastly, gibbon is working on fixing this in his own port. Thanks gibbon!
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Jul 12, 2022 11:23:09 GMT -5
From what I’ve seen in PRBoom, the structure of the command line is against the standard GNU principles for one. There should be a single file (cargs.c?) that will have a standardised structure such as which commands call which function or code, and what happens when you enter it incorrectly.
A lot of this can be done nicely using gnuopt however it isn’t really portable. Luckily I’ve worked on projects in the past for Debian that had it written like gnuopt but without using it (it’s own cli parser). So that is what I will probably do.
Right now it is a mess, but it doesn’t have to be!
|
|
BIG DICK NIGGA
this post is a lie about my bodily proportions
Major Arlene obsessed, 100% verified freakazoid. AKA bzzrak
Posts: 2,279
|
Post by BIG DICK NIGGA on Jul 12, 2022 12:04:42 GMT -5
Can't you just lift the command line "infrastructure" so to sšeak from zdoom or something?
|
|
|
Post by JadingTsunami on Jul 12, 2022 12:35:19 GMT -5
The core problem is not coding, nor is it available and/or interested programmers.
There is an overriding principle among the PrBoom+ caretakers that PrBoom+ is in "maintenance mode." In theory this means no new features, only bug fixes. In practice it's a bit looser as various small features still do make it in, but anything complicated will be rejected as out of scope for "maintenance mode."
The justification for this maintenance mode was threefold:
1. There is no PrBoom+ official owner anymore. 2. dsda-doom is available as a successor and is actively maintained. 3. PrBoom+ can be a sort of "fixed historical standard" to compare other ports against.
One option would be to have PrBoom+ either moved out of "maintenance mode" or the term be expanded to allow reasonable PRs that improve QoL under some overarching guidance (like always fencing new behavior in a config option, for instance).
The basic argument would be: The players clearly still want PrBoom+ to have some basic quality-of-play upgrades, and there are available and interested people to do the coding work: so why stop them?
|
|
BIG DICK NIGGA
this post is a lie about my bodily proportions
Major Arlene obsessed, 100% verified freakazoid. AKA bzzrak
Posts: 2,279
|
Post by BIG DICK NIGGA on Jul 12, 2022 13:12:53 GMT -5
And yet they added UMAPINFO support to it, like, this year.
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Jul 12, 2022 14:02:05 GMT -5
Ain’t in maintenance anymore I’m always breeding chaos.
|
|
|
Post by JadingTsunami on Jul 15, 2022 11:00:27 GMT -5
As information, when recording a demo PrBoom+ will now print a message to the player's view confirming that recording has started.
Similarly when doing "-recordfromto", it will confirm both that the file will be recorded and give a notification when recording has actually started (i.e., the demo file is being appended with new recording information).
While this isn't quite as far-reaching as full command-line verification, it is a compromise solution that hopefully will prove helpful.
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Jul 15, 2022 11:02:47 GMT -5
As information, when recording a demo PrBoom+ will now print a message to the player's view confirming that recording has started. Similarly when doing "-recordfromto", it will confirm both that the file will be recorded and give a notification when recording has actually started (i.e., the demo file is being appended with new recording information). While this isn't quite as far-reaching as full command-line verification, it is a compromise solution that hopefully will prove helpful. It is just a bandaid though, it isn’t fixing the root problem. Which is shoddy code far from a professional standard. PRBOOM Plus Ultimate will live on
|
|
|
Post by JadingTsunami on Jul 15, 2022 11:15:12 GMT -5
It is just a bandaid though, it isn’t fixing the root problem. Which is shoddy code far from a professional standard. I think it's a nice feature in its own right. I agree full command line validation is a valuable feature as well. I think PrBoom-Plus-Ultimate will benefit from having it.
|
|
Deleted
Deleted Member
Posts: 0
|
Post by Deleted on Jul 15, 2022 11:24:52 GMT -5
I’ll probably add something a bit more forceful as an extra step. Like a press enter to continue when using the -record etc feature so it is very clear a recording will be done, along with proper validation.
|
|
|
Post by JadingTsunami on Jul 15, 2022 11:32:20 GMT -5
I’ll probably add something a bit more forceful as an extra step. Like a press enter to continue when using the -record etc feature so it is very clear a recording will be done, along with proper validation. That's an interesting idea. Would be especially useful for players who record from a saved game, or continue/append demos. It can be quite jarring to do this today.
|
|
kvsari
Doomer
I like mapping.
Posts: 266
|
Post by kvsari on Jul 15, 2022 18:21:11 GMT -5
I’ll probably add something a bit more forceful as an extra step. Like a press enter to continue when using the -record etc feature so it is very clear a recording will be done, along with proper validation. That would make it very clear it's recording. I think command line verification goes far enough though.
|
|